Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonlinear Workload - Decimal Ramp Rate #287

Merged
merged 6 commits into from
Nov 17, 2023

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Nov 16, 2023

Nonlinear Workload - Decimal Ramp Rate
An update to the nonlinear workload model to allow for decimal ramp rates, allowing for more granularity in both the ramp as well as the target steady state concurrent users. This involved the following changes:

  • Adding a new field to the DB, target_rate to take in decimal ramp rate and save ramp rate per project
  • Limit the ramp rate between 0.001 and 1.000 and pass the ramp rate directly to agents. This is different from before where the overall ramp rate was divided amongst the number of agents, allowing individual agents to ramp to any rate with staggered start. Now each agent is an isolated non-linear ramp ramping anywhere between 0.001 and 1.000 users/sec.
  • Each agent will now start ramping nonlinear ramp immediately, they no longer have a staggered start. This will allow the overall ramp to hit its steady state at the correct time when before it was delayed by the staggered start of agents.
  • Updated UI to accommodate the changes including limiting ramp rate entry (0-1 user/sec) and QOL changes to Job Details

Example:

  • Agent Ramp Rate: 0.61 user/sec
  • Total Ramp Rate: 4.27 users/sec
  • Number of Agents: 7
  • Ramp Time: 13 min
  • User Duration: 13 min

Expected Steady State Concurrent Users: Ramp Time (secs) x Total Ramp Rate = ~3325 users (475 users per agent)

SINGLE AGENT:
Screenshot 2023-11-17 at 9 42 12 AM

TOTAL RAMP:

Screenshot 2023-11-17 at 9 50 01 AM

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro changed the title decimal ramp rate Nonlinear Ramp Rate - Decimal Ramp Rate Nov 17, 2023
@Zakaria-Kofiro Zakaria-Kofiro changed the title Nonlinear Ramp Rate - Decimal Ramp Rate Nonlinear Ramp Rate - Decimal Ramp Rate ( < 1 users/sec) Nov 17, 2023
@Zakaria-Kofiro Zakaria-Kofiro changed the title Nonlinear Ramp Rate - Decimal Ramp Rate ( < 1 users/sec) Nonlinear Ramp Rate - Decimal Ramp Rate (< 1 users/sec) Nov 17, 2023
@Zakaria-Kofiro Zakaria-Kofiro changed the title Nonlinear Ramp Rate - Decimal Ramp Rate (< 1 users/sec) Nonlinear Workload - Decimal Ramp Rate Nov 17, 2023
@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review November 17, 2023 17:51
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zakaria-Kofiro Zakaria-Kofiro merged commit d9f43e6 into master Nov 17, 2023
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/decimal-ramp-rate branch November 17, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants