Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanent fix for p:pickList bug for script group/datafile selection #255

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Jul 31, 2023

Permanent fix for p:pickList bug by replacing it with dataTables for script group/datafile selection

Bug: https://jira.intuit.com/browse/SRE-27872

This is the permanent fix for the Primefaces UI bug that caused project pages to stall when trying to add scripts or data files to the project. This change switches out the use of the p:pickList component, which was the root cause of the issue due to it sending large payloads with an entry for every script/data file, causing the page to stall on update. We will instead uses two p:dataTable, along with the same picklist buttons, to achieve the same functionality as the non-working component (filtering, on-click select, double click to add/remove, etc). The p:dataTable component is largely recommended to be used over p:pickList when handling large datasets and also offers pagination. It also sends a significantly smaller payload excluding the list of entires that p:pickList includes in it's payload.

This also removes the logging in WorkloadScripts.java that was previously used to debug the issue.

Reference:

Script Groups
Screenshot 2023-07-31 at 4 36 36 PM

DataFiles:
Screenshot 2023-07-31 at 4 42 02 PM
Screenshot 2023-07-31 at 4 42 10 PM

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro changed the title Permanent fix for p:pickList bug by replacing it with dataTables for script group/datafile selection Permanent fix for p:pickList bug for script group/datafile selection Jul 31, 2023
@Zakaria-Kofiro Zakaria-Kofiro merged commit 97502d8 into master Aug 2, 2023
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/picklist-fix branch August 2, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants