Permanent fix for p:pickList bug for script group/datafile selection #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permanent fix for p:pickList bug by replacing it with dataTables for script group/datafile selection
Bug: https://jira.intuit.com/browse/SRE-27872
This is the permanent fix for the Primefaces UI bug that caused project pages to stall when trying to add scripts or data files to the project. This change switches out the use of the
p:pickList
component, which was the root cause of the issue due to it sending large payloads with an entry for every script/data file, causing the page to stall on update. We will instead uses twop:dataTable
, along with the same picklist buttons, to achieve the same functionality as the non-working component (filtering, on-click select, double click to add/remove, etc). Thep:dataTable
component is largely recommended to be used overp:pickList
when handling large datasets and also offers pagination. It also sends a significantly smaller payload excluding the list of entires thatp:pickList
includes in it's payload.This also removes the logging in
WorkloadScripts.java
that was previously used to debug the issue.Reference:
Script Groups
DataFiles:
Please make sure these check boxes are checked before submitting
mvn clean test -P default
** PR review process **