Tank API V2 Clients Release #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 23, 2023 10:29
fix: supports both normal and gzip file uploads fix: updating get specific script to script JSON description, download handles content fix: updated max file size and added exception handling for file exceptions fix: set debug to false fix: group all exception handlers fix: updating prefix fix: unneeded file fix: reverting file change Revert "fix: reverting file change" This reverts commit 0ba90f6. fix: revert file fix: reverting file as well fix: detailed error msg for incorrect request
This reverts commit 66d2ca4.
…, and testing agent client with APIHarness
added 16 commits
June 12, 2023 16:26
shawn-h-park
approved these changes
Jun 16, 2023
added 4 commits
June 27, 2023 22:16
This reverts commit 6db2e74.
Zakaria-Kofiro
added a commit
that referenced
this pull request
Jun 30, 2023
This reverts commit ec74378.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tank API V2 Clients Release
This PR contains the addition of Tank V2 API clients to replace the existing V1 clients, as well as updated references in the codebase to point to new V2 endpoints and cloud-api files.
Changes:
agent: Main agent logic (apiharness) now uses V2 Clients to make calls while running tests, replacing the agent ready and update agent status calls (PUT /v2/agent/instance/status/instance-id), among other calls. Agent Startup has also been updated with the V2 routes to grab the required files to start agents. Agent Standalone has also been updated with V2 references.api: Cloud API code, mainlyVMTracker, that controllers interaction with jobs and agents have been moved out of the V1 cloud api module into the sharedapimodule along with its data models. Since several parts of the codebase depend on this code and models, it makes more sense to move it to the common API module that contains similar logic. Most of the file changes in this PR are import reference changes to point to this new location. Dependency Injection has also been updated to use Java EE CDI across the project over Spring, since switching over to using the Spring Framework for dependency injection would require updating the entire codebase. Java EE CDI will be kept project-wide for now.rest-mvc: Addition of V2 API Clients using Spring WebClient along with Dep Injection changes, log4j configurations and updated references to cloud api code. All references to script data models have been moved to V1 while external scripts are being updated to support V2.rest: Minor changes to V1 modulerestto reference the moved cloud api code to pass build over removing in this PR. The module will eventually be sunset as a whole in a follow-up PR.tank_vmManager: Controller logic (i.eJobController) now referencing the moved cloud api codetools: Updated Tank tools to reference new V2 clients, as well as added changes to increase the speed of certain processes (the initial pull for project/scripts list in Agent Debugger Tool is now almost instant regardless of the number of projects/scripts).web: Updated reference to cloud api code, as well as the addition of a temporary banner warning users to replace their version of Tank tools with the updated version with V2 clients. The banner follows the user across screens until closed, where it will stay closed for the session until the user logs in again.Log4j Changes: The introduction of Spring WebClient also introduced a log4j issue affecting logging configurations across modules. These errors affected the creation of logs and resulted in dropped logs. This was resolved by updating each affected module's maven plugins assembly.xml to exclude a cached log4j file while ensuring there were no changes to the build process of the updated modules.
Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **