Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit tests for UserServiceV1 #168

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Add Unit tests for UserServiceV1 #168

merged 1 commit into from
Oct 25, 2021

Conversation

shawn-h-park
Copy link
Contributor

@shawn-h-park shawn-h-park commented Oct 22, 2021 •
edited
Loading

Code Coverage: - (1) Increase code coverage & quality by adding unit tests to UserServiceV1, (2) Inject UserDao
Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

kevin-mcgoldrick
kevin-mcgoldrick approved these changes Oct 22, 2021
View reviewed changes
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin-mcgoldrick kevin-mcgoldrick merged commit eefee1c into master Oct 25, 2021
@kevin-mcgoldrick kevin-mcgoldrick deleted the User-Service-Validation branch December 9, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-mcgoldrick kevin-mcgoldrick kevin-mcgoldrick approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawn-h-park @kevin-mcgoldrick