Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing a custom HttpMessageHandler #257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

czietsman
Copy link

I would like to be able specify a custom HTTP message handler so that I can capture the 'intuit_tid' header and add it to our logs.

I've added an optional HttpMessageHandler innerHandler = null where it made sense and passed it through.

The following decisions were made:

  • custom handler was not added to DiscoveryClient(string discoveryUrl), since there already exists another constructor DiscoveryClient(string authority = OidcConstants.Discovery.IssuerUrl, HttpMessageHandler innerHandler = null) which would conflict
  • custom handler was not added to TokenClient in the constructor for RefreshTokenHandler, since there exists an overload where a TokenClient can be passed to the RefreshTokenHandler

@nimisha84
Copy link
Collaborator

nimisha84 commented Feb 1, 2023

Thanks for the PR. I had moved to a different team and SDK ownership has been transferred. CLosing off the pending PRs. Looks like with this change, if existing devs directly call the different oauth lib clients, they can break. I would suggest creating another constructor instead of updating the existing one for your use case. Please update us when you are ready with the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants