Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versionOfTLS() depends on www.howsmyssl.com, which didn't renew its own SSL cert! #13

Closed
PaulStoffregen opened this issue Nov 27, 2019 · 6 comments

Comments

@PaulStoffregen
Copy link

Today our site stopped processing credit card authorizations. I tracked the problem down to versionOfTLS() in BaseCurl.php. It makes a connection to https://www.howsmyssl.com/a/check

https://github.com/intuit/PHP-Payments-SDK/blob/master/src/HttpClients/core/BaseCurl.php#L151

Today howsmyssl.com's own SSL certificate expired, causing versionOfTLS() to fail, in turn causing setSSLConfig() to throw a PHP exception which prevents any Quickbooks Payments communication!

@hlu2
Copy link
Contributor

hlu2 commented Nov 27, 2019

Fixing it now. Will make a quick release.

@PaulStoffregen
Copy link
Author

Looks like howsmyssl has just now updated their site with a free Let's Encrypt cert.

Still, maybe not such a great design to depend upon this free site?

hlu2 added a commit that referenced this issue Nov 27, 2019
@hlu2
Copy link
Contributor

hlu2 commented Nov 27, 2019

Definitely not. It was there when we just started disabling tls 1.1 and developers are not understanding which tls version they are using. It is no longer necessary.

@hlu2 hlu2 closed this as completed Nov 27, 2019
@PaulStoffregen
Copy link
Author

You might also consider updating cacert.pem. It appears to be 2 years old.

@hlu2
Copy link
Contributor

hlu2 commented Nov 27, 2019

I disable the SSL checkings as well. Right now, it will not "verify" the certificate to see if it is signed by a valid authority. For maintenance purposes, "accept all certificate" is the default option.

@hlu2
Copy link
Contributor

hlu2 commented Nov 27, 2019

In case somebody needs the validation, updated the cacert.pem as well.

@hlu2 hlu2 reopened this Nov 27, 2019
@hlu2 hlu2 closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants