Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the thumb shadow of CardPartMultiSlider configurable #271

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

rcole34
Copy link
Contributor

@rcole34 rcole34 commented Apr 8, 2021

Simulator Screen Shot - iPhone 11 Pro - 2021-04-08 at 12 45 53

Before you make a Pull Request, read the important guidelines:

Issue Link 🔗

  • Is this a bug fix or a feature? **Feature!**
  • Does it break any existing functionality? **No**

Goals of this PR 🎉

  • Why is the change important? **Allows custom shadows on the CardPartMultiSlider thumb images**
  • What does this fix?
  • How far has it been tested?

How Has This Been Tested 🔍

Manually tested shadows with different configurations to confirm that it was having the desired effect

  • User Interface Testing
  • Application Testing

Test Configuration 👾

  • Xcode version: 12.4
  • Device/Simulator iPhone 11 Pro
  • iOS version 14.4 || MacOSX version

Things to check on 🎯

  • My Pull Request code follows the coding standards and styles of the project
  • I have worked on unit tests and reviewed my code to the best of my ability
  • I have used comments to make other coders understand my code better
  • My changes are good to go without any warnings
  • I have added unit tests both for the happy and sad path
  • All of my unit tests pass successfully before pushing the PR
  • I have made sure all dependent downstream changes impacted by my PR are working

@badrinathvm badrinathvm self-requested a review April 8, 2021 19:50
Copy link
Contributor

@badrinathvm badrinathvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@croossin croossin merged commit 75c301d into intuit:master Apr 8, 2021
@rcole34 rcole34 deleted the multislider_shadows branch April 8, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants