Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing cards width within CardsViewController when the view controller frame is changed. #170

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Fixing cards width within CardsViewController when the view controller frame is changed. #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions CardParts/src/Classes/CardsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,18 +82,21 @@ open class CardsViewController : UIViewController, UICollectionViewDataSource, U

view.addConstraints(NSLayoutConstraint.constraints(withVisualFormat: "H:|[collectionView]|", options: [], metrics: nil, views: ["collectionView" : collectionView!]))
view.addConstraints(NSLayoutConstraint.constraints(withVisualFormat: "V:|[collectionView]|", options: [], metrics: nil, views: ["collectionView" : collectionView!]))
cardCellWidth.accept(view.bounds.width - (CardParts.theme.cardCellMargins.left + CardParts.theme.cardCellMargins.right))
}

open override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
cardCellWidth.accept(size.width - (CardParts.theme.cardCellMargins.left + CardParts.theme.cardCellMargins.right))
cardCellWidth.accept(size.width.rounded() - (CardParts.theme.cardCellMargins.left + CardParts.theme.cardCellMargins.right))
invalidateLayout()
}

// functionality that happens when the view appears
open override func viewDidAppear(_ animated: Bool) {
super.viewDidAppear(animated)

let newValue = view.bounds.width.rounded() - (CardParts.theme.cardCellMargins.left + CardParts.theme.cardCellMargins.right)
if newValue != cardCellWidth.value {
cardCellWidth.accept(newValue)
}

// make sure that we set this as the first time we are checking for visibility
lastScrollViewBounds = nil
notifyCardsVisibility()
Expand Down