Swift 5 support #132
Merged
Swift 5 support #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 13, 2019 11:24
…need to be there in order for the code to function, so a crash would be a good idea if they aren't.
…ped the RxSwift, RXCocoa and RXGesture to the Swfit 5 versions.
croossin
reviewed
Apr 13, 2019
Co-Authored-By: lwdupont <[email protected]>
|
I pulled that fix, and did a pod update again when running the example, still no changes, and it's on Swift 5. Thanks for catching that @croossin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #130
Check out my force unwrap decision. Normally I don't do that, but I was thinking that it would be best to crash if those values aren't found.
Also updated the Travis yaml file so hopefully the build will work, if not I'll work on fixing that.