Refactor to use rspec filtering #215
Conversation
Restore standard/rake and use java? method. Use add_setting in Rspec config. Use free boolean methods, restore some janky adapter loading stuff.
djberg96
force-pushed
the
rspec_refactor
branch
from
f1995ad to
f5a0118
Compare
|
@sferik What do you think of this approach? |
|
I like this approach. I'll be happy to merge it when the build failures are fixed. |
|
Does this supersede #213? If so, can you close that PR? |
|
@sferik Thanks. I'm still working out some JRuby/Truffleruby things, probably shoulda left it as a draft. I'll ping you when I think it's ready. |
|
Looks like tests are passing. Is this ready for review now? |
|
@sferik I could tinker with it some more, but I guess it's ready. The main issue was that the tags weren't as useful as I hoped since the Why was this closed? |
|
Oops. I must have accidentally hit “Comment and Close” instead of “Comment”. Pressing “Reopen and comment” now. |
Just a draft PR for now to replace some inline logic with rspec filters and tags. The tags are useful for both config and for the command line.
I'm also tweaking the Jruby handling a bit to be more generic since there's now also Truffleruby.