fix: adds I18nT keyword into key collection #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bccef56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ota-meshi
requested changes
Feb 18, 2024
lib/utils/collect-keys.ts
Outdated
Comment on lines
213
to
214
| (node.key.name === 'path' && (['i18n', 'i18n-t', 'i18nt'].includes(node.parent.parent.name)) || | ||
| (node.key.name === 'keypath' && ['i18n-t', 'i18nt'].includes(node.parent.parent.name))) |
There was a problem hiding this comment.
Could you please use rawName to determine more accurately?
Suggested change
| (node.key.name === 'path' && (['i18n', 'i18n-t', 'i18nt'].includes(node.parent.parent.name)) || | |
| (node.key.name === 'keypath' && ['i18n-t', 'i18nt'].includes(node.parent.parent.name))) | |
| (node.key.name === 'path' && | |
| (node.parent.parent.name === 'i18n' || | |
| node.parent.parent.name === 'i18n-t' || | |
| node.parent.parent.rawName === 'I18nT')) || | |
| (node.key.name === 'keypath' && | |
| (node.parent.parent.name === 'i18n-t' || | |
| node.parent.parent.rawName === 'I18nT')) |
There was a problem hiding this comment.
Thanks for the suggestion, I've fixed it accordingly.
…t-plugin-vue-i18n into fix/447/i18nt-tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #447