Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Make import-fresh a proper dependency #433

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix(deps): Make import-fresh a proper dependency #433

merged 2 commits into from
Oct 2, 2023

Conversation

wolfgangwalther
Copy link
Contributor

This is not a devDependency, because it's used in regular code in lib/utils/collect-keys.ts. This seems like an oversight in #377.

It causes errors like this for me:

    Failed to load plugin '@intlify/vue-i18n' declared in '.eslintrc.js': @intlify/eslint-plugin-vue-i18n tried to access import-fresh, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

This is not a devDependency, because it's used in regular code in lib/utils/collect-keys.ts. This seems like an oversight in #377.
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2023

🦋 Changeset detected

Latest commit: cb9cb35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@intlify/eslint-plugin-vue-i18n Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ota-meshi ota-meshi changed the title chore(deps): Make import-fresh a proper dependency fix(deps): Make import-fresh a proper dependency Oct 2, 2023
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants