Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update @intlify dependencies to v9.3.0-beta.19 #382

Merged
merged 2 commits into from
Jun 18, 2023
Merged

feat(deps): update @intlify dependencies to v9.3.0-beta.19 #382

merged 2 commits into from
Jun 18, 2023

Conversation

dargmuesli
Copy link
Contributor

Please change this PR's base branch to a newly created beta branch 🙌

To resolve nuxt-modules/i18n#2098

@dargmuesli dargmuesli marked this pull request as draft June 9, 2023 23:14
@dargmuesli dargmuesli marked this pull request as ready for review June 10, 2023 16:10
@dargmuesli
Copy link
Contributor Author

Now that #377 is merged, this one can be used to create a beta release as well, it seems :) @ota-meshi

@dargmuesli
Copy link
Contributor Author

@kazupon what do you think about this change?

@@ -1,4 +1,4 @@
lockfileVersion: '6.1'
lockfileVersion: '6.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it downgrade? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm v8.6.2 reverted the lockfile update seemingly: https://github.com/pnpm/pnpm/releases/tag/v8.6.2
interesting decision for sure, I was confused by that right now as well.

@kazupon
Copy link
Member

kazupon commented Jun 14, 2023

@dargmuesli
I think this PR is good since we can resolve nuxt-modules/i18n#2098 issue

@kazupon
Copy link
Member

kazupon commented Jun 15, 2023

I think we release as v3.0.0-beta, because deps has beta version

@dargmuesli
Copy link
Contributor Author

That's a good idea!

@ota-meshi
Copy link
Member

Thank you for this PR. The changes look good, but I have a question. Why do we need a beta branch?

@ota-meshi ota-meshi added Type: Dependency Dependencies fixes Type: Breaking Includes backwards-incompatible fixes labels Jun 15, 2023
@kazupon
Copy link
Member

kazupon commented Jun 16, 2023

@ota-meshi

Why do we need a beta branch?

I mean we can release beta version on master branch!

@dargmuesli
Copy link
Contributor Author

If it's possible to release a beta version from the master branch as well, you can for sure do so!

In other projects I worked on I'm used to be required to add a beta branch for beta releases, but that's just me.

@ota-meshi
Copy link
Member

Thank you for sharing your thoughts! I believe we can release a beta version from master branch.

@ota-meshi ota-meshi merged commit c848b43 into intlify:master Jun 18, 2023
@dargmuesli dargmuesli deleted the beta branch June 18, 2023 03:12
@ota-meshi
Copy link
Member

I'm trying to do a beta version release, but shipjs doesn't work. For some reason I get an error with the new syntax and node: protocol that should be available in Nodejs v18 🤔

@dargmuesli
Copy link
Contributor Author

Yeah, weird. Seems it's not using node?

@ota-meshi
Copy link
Member

The esm package seems to be the cause of the error. It uses the old parser.

https://www.npmjs.com/package/esm
https://github.com/algolia/shipjs/blob/82d001f5a4ad23cde7efebb3b1d450229f050563/packages/shipjs/bin/shipjs#L3

I got around it by replacing it with one that uses esbuild.

https://github.com/intlify/eslint-plugin-vue-i18n/blob/master/shipjs-cli.cjs

We may need to replace shipjs with something else 😓

Copy link
Member

kazupon commented Jun 18, 2023

I feel that shipjs is mostly in the maintenance phase and ESM support is almost never going to happen in the future.

I'm not using shipjs for releases and changelog generation with vue-i18n, nuxt i18n module and others.
When I first started using shipjs, automatic changelog generation was not supported in github releases.
We should try to replace it with another tool.

I use a tool called bumpp for releases now.
https://github.com/antfu/bumpp

I use bumpp for releases, and GitHub Releases for changelog generation. However, GitHub Releases does not support the file CHANGELOG.md.

I want to support file changelog generation as well, so I created my own tool called gh-changelogen.
https://github.com/kazupon/gh-changelogen

This tool is supposed to work with github actions. bumpp releases, github actions can detect git tags, so I can use github actions to commit the file CHANGELOG.md using github releases and sync it with the file CHANGELOG.md. and then commit the file CHANGELOG.md and sync it.

There are also other tools that the Vue community has created to generate changelogs, such as

We may want to consider these for eslint-plugin-vue-i18n. 😉

@dargmuesli
Copy link
Contributor Author

Great overview, thanks kazu! ❤️ Would you try what fits best for this project, @ota-meshi? As I don't have write permissions on this repo, I'd have a hard time to do a release.

@dargmuesli
Copy link
Contributor Author

Oh, I just saw you already did a release 🥳 I'll try it out rn!

@ota-meshi
Copy link
Member

I often use changeset for my package releases.
https://github.com/changesets/changesets
It is also used by svelte and stylelint.
However, in order for this to work well, we need to introduce changeset-bot.
https://github.com/apps/changeset-bot
What do you think about using changeset for the releases of this package?

@kazupon
Copy link
Member

kazupon commented Jun 19, 2023

I am of course fine with you, using whatever tools you like!
Do I just install the changelogset-bot in the intlify organization?

@ota-meshi
Copy link
Member

Do I just install the changelogset-bot in the intlify organization?

The bot will send comments to the PR, so I think it's a good idea to install it only in the repositories we use.
I installed it.

Copy link
Member

kazupon commented Jun 24, 2023

Okay, Let's ship with the tools you are comfortable with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Includes backwards-incompatible fixes Type: Dependency Dependencies fixes
Projects
None yet
3 participants