-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): update @intlify dependencies to v9.3.0-beta.19 #382
Conversation
Now that #377 is merged, this one can be used to create a |
@kazupon what do you think about this change? |
@@ -1,4 +1,4 @@ | |||
lockfileVersion: '6.1' | |||
lockfileVersion: '6.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it downgrade? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm v8.6.2 reverted the lockfile update seemingly: https://github.com/pnpm/pnpm/releases/tag/v8.6.2
interesting decision for sure, I was confused by that right now as well.
@dargmuesli |
I think we release as v3.0.0-beta, because deps has beta version |
That's a good idea! |
Thank you for this PR. The changes look good, but I have a question. Why do we need a |
I mean we can release beta version on |
If it's possible to release a beta version from the master branch as well, you can for sure do so! In other projects I worked on I'm used to be required to add a beta branch for beta releases, but that's just me. |
Thank you for sharing your thoughts! I believe we can release a beta version from |
I'm trying to do a beta version release, but |
Yeah, weird. Seems it's not using node? |
The https://www.npmjs.com/package/esm I got around it by replacing it with one that uses esbuild. https://github.com/intlify/eslint-plugin-vue-i18n/blob/master/shipjs-cli.cjs We may need to replace shipjs with something else 😓 |
I feel that shipjs is mostly in the maintenance phase and ESM support is almost never going to happen in the future. I'm not using shipjs for releases and changelog generation with vue-i18n, nuxt i18n module and others. I use a tool called I use I want to support file changelog generation as well, so I created my own tool called This tool is supposed to work with github actions. There are also other tools that the Vue community has created to generate changelogs, such as We may want to consider these for |
Great overview, thanks kazu! ❤️ Would you try what fits best for this project, @ota-meshi? As I don't have write permissions on this repo, I'd have a hard time to do a release. |
Oh, I just saw you already did a release 🥳 I'll try it out rn! |
I often use |
I am of course fine with you, using whatever tools you like! |
The bot will send comments to the PR, so I think it's a good idea to install it only in the repositories we use. |
Okay, Let's ship with the tools you are comfortable with! |
Please change this PR's base branch to a newly created
beta
branch 🙌To resolve nuxt-modules/i18n#2098