Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only return transform for vue files #428

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

BobbieGoede
Copy link
Member

@BobbieGoede BobbieGoede commented Dec 20, 2024

This may resolve sourcemap issues, credits to @userquin

@BobbieGoede BobbieGoede requested a review from userquin December 20, 2024 23:58
@userquin
Copy link
Member

We should avoid transforming things like inline vue styles, quite sensible for sourcemaps, with this PR we only transform .vue files.

Copy link
Member

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@userquin
Copy link
Member

userquin commented Dec 21, 2024

Maybe we should just remove returning any code from the transform hook, we're not transforming anything on it, just adding some id for the vue compiler...

@kazupon kazupon added Type: Improvement Includes backwards-compatible fixes Package: unplugin-vue-i18n labels Dec 21, 2024
@kazupon kazupon merged commit 15e7d54 into main Dec 21, 2024
10 checks passed
@kazupon kazupon deleted the fix/directive-transform-return branch December 21, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: unplugin-vue-i18n Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants