Make "default_storage" produce a "Storage" object (typeddjango#1665)

The actual "DefaultStorage" storage class is a "LazyObject" proxy, which ought to be a generic "LazyObject[Storage]", but doesn't support functionality as a proxy. Currently, "default_storage" doesn't have a useful annotation.
intgr · Sep 11, 2023 · 9cabc5a · 9cabc5a
1 parent 12422e6
commit 9cabc5a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/django-stubs/core/files/storage/__init__.pyi b/django-stubs/core/files/storage/__init__.pyi
@@ -24,4 +24,5 @@ def get_storage_class(import_path: str | None = ...) -> type[Storage]: ...
 class DefaultStorage(LazyObject): ...
 
 storages: StorageHandler
-default_storage: DefaultStorage
+# default_storage is actually an instance of DefaultStorage, but it proxies through to a Storage
+default_storage: Storage
diff --git a/scripts/stubtest/allowlist.txt b/scripts/stubtest/allowlist.txt
@@ -14,6 +14,9 @@ django.contrib.auth.migrations.*
 django.contrib.flatpages.migrations.*
 django.contrib.contenttypes.migrations.*
 
+# default_storage is actually an instance of DefaultStorage, but it proxies through to a Storage
+django.core.files.storage.default_storage
+
 # BaseArchive abstract methods that take no argument, but typed with arguments to match the Archive and TarArchive Implementations
 django.utils.archive.BaseArchive.list
 django.utils.archive.BaseArchive.extract