[mock_uss/scd] Handle retrieval of op intent details when USS is down according to SCD0005+SD0010 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… according to SCD0005+SD0010
BenjaminPelletier
approved these changes
Nov 13, 2023
monitoring/monitorlib/locality.py
Outdated
| return -1 | ||
|
|
||
| def highest_priority(self) -> int: | ||
| return 100 |
There was a problem hiding this comment.
This is not canonical and rather just trying to reflect choices that may not yet have been firmly made, but I think best guess is that only one priority level will be used. So, this is likely to be 0.
There was a problem hiding this comment.
OK, will update with a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in the mock USS handling of retrieval of operational intent details in case the USS is declared as down at the and does not answer for the details.
This adds two values in the locality object regarding the lowest and highest bounds for the priority levels the regulation allows.
I've put values for the existing localities, I think
Switzerlandmay be correct, but I have no idea forUnitedStatesIndustryCollaborationso I put the same values. Please LMK if that should be otherwise.Note: this PR depends on interuss/dss#971 in order to be actually useful, since currently the DSS always returns "Unknown" for USS availability state in operational intents.