Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[terraform-google][helm] Set SSL policy to enforce secure TLS connections #997

Merged
merged 3 commits into from
Feb 14, 2024
Merged

[terraform-google][helm] Set SSL policy to enforce secure TLS connections #997

merged 3 commits into from
Feb 14, 2024

Conversation

barroco
Copy link
Contributor

@barroco barroco commented Feb 7, 2024 •
edited
Loading

This PR creates a SSL policy which enforces secure TLS connection and updates the helm chart to assign the SSL policy to the DSS Gateway ingress.

Tested on google cloud: https://dss.ci.google-interuss.uspace.dev
TLS 1.0 and 1.1 not offered.

Another PR will address tanka deployment

@barroco barroco marked this pull request as ready for review February 7, 2024 09:55
@barroco barroco marked this pull request as draft February 7, 2024 12:04
@barroco barroco changed the title [terraform][google] Set SSL policy to enforce secure TLS connections [terraform][google] Set SSL policy to enforce secure TLS connections (Helm only) Feb 8, 2024
@barroco barroco changed the title [terraform][google] Set SSL policy to enforce secure TLS connections (Helm only) [terraform][google] Set SSL policy to enforce secure TLS connections (Helm) Feb 8, 2024
@barroco barroco marked this pull request as ready for review February 8, 2024 13:03
@barroco barroco changed the title [terraform][google] Set SSL policy to enforce secure TLS connections (Helm) [terraform-google][helm] Set SSL policy to enforce secure TLS connections Feb 8, 2024
@barroco barroco mentioned this pull request Feb 8, 2024
Merged
BenjaminPelletier
BenjaminPelletier approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@BenjaminPelletier BenjaminPelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but probably Marc (and yourself) will probably be better indicators of technical correctness than me :)

@barroco barroco merged commit 1ea7ebf into interuss:master Feb 14, 2024
6 checks passed
@barroco barroco mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcadamsge marcadamsge marcadamsge approved these changes

@BenjaminPelletier BenjaminPelletier BenjaminPelletier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barroco @BenjaminPelletier @marcadamsge