Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scd] check subscription version is present and correct when deleting #986

Merged

Conversation

Shastick
Copy link
Contributor

@Shastick Shastick commented Jan 11, 2024

Discovered that the version of a subscription was plainly ignored when writing some tests for the deletion endpoint.

With the present fix we obtain the expected failure when:

  • the version is missing
  • the version is wrong

While the deletion functionality still works when the provided version is correct.

@Shastick Shastick force-pushed the scd-sub-deletion-version-check branch from 4dc0650 to 19b6817 Compare January 25, 2024 07:58
@Shastick
Copy link
Contributor Author

With the latest release of the prober (v0.0.3) the tests pass. Thanks @BenjaminPelletier !

@Shastick Shastick marked this pull request as ready for review January 25, 2024 08:04
@BenjaminPelletier BenjaminPelletier merged commit b423986 into interuss:master Jan 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants