Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Remove rid database v3 backward compatibility (RID schema version 4 is required after this commit) #1142

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

barroco
Copy link
Contributor

@barroco barroco commented Jan 2, 2025

Back in 2021, support for backward compatiblity was kept to keep support for schema v3 and allow production users to migrate to v4 at their pace. 3 years later and due to the opportunity to simplify the switch to yugabyte, this PR removes the support for rid database v3 schemas.

@barroco barroco changed the title [cleanup] Remove rid database v3 backward compatibility [cleanup] Remove rid database v3 backward compatibility (RID schema version 4 is required past this commit) Jan 2, 2025
@barroco barroco marked this pull request as ready for review January 6, 2025 13:40
Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor issue to be fixed before merging, see comment.

pkg/rid/store/cockroach/store.go Show resolved Hide resolved
@barroco barroco changed the title [cleanup] Remove rid database v3 backward compatibility (RID schema version 4 is required past this commit) [cleanup] Remove rid database v3 backward compatibility (RID schema version 4 is required after this commit) Jan 7, 2025
@barroco barroco merged commit 16051aa into interuss:master Jan 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants