-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmds][scd/store] Add 'db-manager scd-evict' subcommand enabling listing and deletion of expired SCD entities #1116
Conversation
6390f18
to
f33d832
Compare
f33d832
to
b8b2ff9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will find a first round of comments. In addition, I think we could leverage the infrastructure used for RID to automate the tests you have made manually without too much effort: https://github.com/interuss/dss/blob/master/Makefile#L113.
b8b2ff9
to
d02ae8c
Compare
973e677
to
f3a6bfa
Compare
FYI still need to test manually the CLI + add unit tests. |
…ing and deletion of expired SCD entities
Hey @mickmis where are we currently at with this tool? We just updated to v0.18 but we've accumulated a significant number of dangling subscriptions over the last month and they are having a significant affect on latency so we're hoping to leverage this tool ASAP |
Hi @callumdmay, thank you for your patience. @mickmis is ooo today, he will get back to you on Monday and should be able to progress on this with top priority. |
Great to hear and thanks for all the work here! |
Hi @callumdmay, sorry I've had to slow down significantly my work on this issue for the last few weeks. I've actually resumed that last Thursday and I expect this PR to be merged by tomorrow. |
f3a6bfa
to
ec6e2c5
Compare
@barroco this is now ready for another review. I've added unit tests and tested the tool manually in addition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as a first version. Please take a note on the performance concern.
Addresses #1074
This PR adds a CLI tool
db-manager scd-evict
that enables deletion of expired entities. See enclosed README for more details on its usage.Do note the approach taken when entities do not have end times: the last update times are used.