-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for deprecated vscode.proposed.d.ts #771
Conversation
According to microsoft/vscode#136964 (comment), this line: vscode-objectscript/package.json Line 52 in 9dc677a
should be changed to: "enabledApiProposals": ["fileSearchProvider", "textSearchProvider"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave the old line in there as well, until after 1.63 ships as Stable in December. And even then only remove it if we bump our minimum required version to 1.63 (currently it is 1.43). Otherwise people trying to used the proposed APIs in current Stable (1.62.2) or earlier are likely to find they no longer work.
With microsoft/vscode-dts#11 merged we will be able to continue to use |
fyi - this has been merged and published and you can simply run |
Build will fail until the vscode team will publish the latest vscode-dts