Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for deprecated vscode.proposed.d.ts #771

Merged
merged 5 commits into from
Nov 15, 2021
Merged

fix for deprecated vscode.proposed.d.ts #771

merged 5 commits into from
Nov 15, 2021

Conversation

daimor
Copy link
Member

@daimor daimor commented Nov 12, 2021

Build will fail until the vscode team will publish the latest vscode-dts

@isc-bsaviano
Copy link
Contributor

According to microsoft/vscode#136964 (comment), this line:

"enableProposedApi": true,

should be changed to:

  "enabledApiProposals": ["fileSearchProvider", "textSearchProvider"],

@isc-bsaviano isc-bsaviano changed the title fix for depracated vscode.proposed.d.ts fix for deprecated vscode.proposed.d.ts Nov 12, 2021
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave the old line in there as well, until after 1.63 ships as Stable in December. And even then only remove it if we bump our minimum required version to 1.63 (currently it is 1.43). Otherwise people trying to used the proposed APIs in current Stable (1.62.2) or earlier are likely to find they no longer work.

@isc-bsaviano
Copy link
Contributor

With microsoft/vscode-dts#11 merged we will be able to continue to use vscode-dts dev without specifying the specific proposals

@jrieken
Copy link

jrieken commented Nov 15, 2021

With microsoft/vscode-dts#11 merged we will be able to continue to use vscode-dts dev without specifying the specific proposals

fyi - this has been merged and published and you can simply run vscode-dts dev BUT you do need to spell out each proposal in your extensions package.json file first, like so https://github.com/microsoft/vscode-anycode/blob/e04704aaf6d813c4e882f54dd65f04ff16b6c08b/package.json#L8

@isc-bsaviano isc-bsaviano marked this pull request as ready for review November 15, 2021 13:54
@isc-bsaviano isc-bsaviano merged commit 2044f4b into master Nov 15, 2021
@isc-bsaviano isc-bsaviano deleted the vscode-types branch November 15, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants