Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (icm): added possibility to empty database and site folder (#317) #320

Conversation

MoritzKarsch
Copy link

PR Type

  • Feature
  • Code style update (formatting, local variables)

Release

Be sure to include PR label major, minor or patch when merging into main. This determines which part of the semantic version number needs to be bumped automatically.

What Is the Current Behavior?

The user has no way to empty the database and site folder through the Helm chart.

Issue Number: Closes #317

What Is the New Behavior?

The user can set the new value .Values.cleanup.enabled to true. Before the deployment, a job is started to empty the database and the site folder. Subsequently, the ICM-AS deployment is retriggered, and a DBInit is executed.

Does this PR Introduce a Breaking Change?

  • Yes
  • No

Other Information

The template for creating the environment variables has been moved to a separate template.

Copy link
Contributor

@skiesewetter-intershop skiesewetter-intershop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets talk about before merging

@MoritzKarsch MoritzKarsch added enhancement New feature or request icm Intershop ICM related helm chart changes icm-as Intershop ICM application server related helm chart changes labels Jun 13, 2023
@khauser khauser added the patch Semantic version increment 0.0.x label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request icm Intershop ICM related helm chart changes icm-as Intershop ICM application server related helm chart changes patch Semantic version increment 0.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants