Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inputmode=url #1502

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

bwbroersma
Copy link
Collaborator

Fix #1328 by running:

$ grep -RE 'form action="(https://internet.nl)?/(site|mail)/" method="POST"|type="text"' interface -l \
| xargs -n1 sed -r -i 's@(form action="(https://internet.nl)?/(site|mail)/" method="POST") novalidate@\1@g;s/(type=)"(url|email)"/\1"text" inputmode="url"/g'

Fix internetstandards#1328 by running:

    grep -RE 'form action="(https://internet.nl)?/(site|mail)/" method="POST"|type="text"' interface -l | xargs -n1 sed -r -i 's@(form action="(https://internet.nl)?/(site|mail)/" method="POST") novalidate@\1@g;s/(type=)"(url|email)"/\1"text" inputmode="url"/g'
@mxsasha
Copy link
Collaborator

mxsasha commented Sep 19, 2024

I see you originally said:

It would need some extensive browser testing to be sure (note I also change the embed code).

This is something we'd need to test for specifically for 1.9 then.

@mxsasha mxsasha merged commit 46b4042 into internetstandards:main Sep 19, 2024
13 checks passed
@mxsasha
Copy link
Collaborator

mxsasha commented Sep 19, 2024

Deploying this on dev-docker now, so if you want to try different browsers, you can do it there.

@bwbroersma
Copy link
Collaborator Author

This is something we'd need to test for specifically for 1.9 then.

The previous change was trickier: going from type=text to url/email was being more strict in input, and it needed a novalidate on the form. This change is loosening to the type=text again, removing the novalidate and only hinting via inputmode. So this change is less scary IMHO.

@bwbroersma
Copy link
Collaborator Author

  • On an iPhone 14 Pro with iOS 18 in Lockdown + inPrivate mode:
    image

@mxsasha mxsasha added this to the v1.9 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use input inputmode
2 participants