Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display version number of Internet.nl code in frontend #494

Closed
baknu opened this issue Dec 18, 2020 · 3 comments
Closed

Display version number of Internet.nl code in frontend #494

baknu opened this issue Dec 18, 2020 · 3 comments
Assignees
Milestone

Comments

@baknu
Copy link
Contributor

baknu commented Dec 18, 2020

Display version number of Internet.nl code in frontend, e.g. in footer.

@baknu baknu added this to the v1.4 milestone Feb 3, 2021
@baknu baknu modified the milestones: v1.4, v1.5 Mar 5, 2021
@gthess
Copy link
Collaborator

gthess commented Jul 16, 2021

As discussed during a meeting this could reflect the latest tag release (e.g., v1.3.2).
This would make sense only if all the live versions are done by checking out version tags.

If a version needs to go live that is not yet part of a full release (e.g., updating straight from the master branch), or different development versions are live, then using the git commit hash would be easier to understand.

This could be integrated in the make translations command (necessary while deploying) to get the version string from git and replace it in the translations/*/main.po files before generating the django files. That would mean that a distinct place holder needs to be in those files for a trivial text replace logic.
git describe --tags and git rev-parse --short HEAD could prove useful to getting the version string.

Then optionally the displayed version could be a link to <github_address>/Internet.nl/blob/<tag or commit hash>/Changelog.md.

@baknu
Copy link
Contributor Author

baknu commented Apr 7, 2023

@mxsasha Could we:

  1. align the version info to the right (currenty it is directly after the tagline "Internet.nl is an initiative of the Internet community and the Dutch government.");

  2. make sure that for smaller screens/windows the version info is placed under the mentioned tagline on a new line.

Ad 1:
20230407_screen1_internetnl

Ad 2:
20230407_screen2_internetnl

@baknu baknu reopened this Apr 7, 2023
@bwbroersma
Copy link
Collaborator

A solution would be wrapping

v{{ "VERSION"|get_settings_value }}

with a

<div class="version">..

and then add some

  footer .wrap .version {
    float: right;
  }

in the @media (min-width:800px) block and add a

  clear: both;

to the footer hr style:

/* footer */
footer hr {
background: white;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants