Skip to content

Commit

Permalink
Set cache-max-negative-ttl in DNS queries
Browse files Browse the repository at this point in the history
(in addition to cache-max-ttl)
  • Loading branch information
mxsasha committed Feb 28, 2024
1 parent 5854529 commit 07b069a
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions checks/tasks/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,11 @@ def ub_ctx(self):
self._ub_ctx.zone_add("test.", "transparent")

self._ub_ctx.set_option("cache-max-ttl:", str(settings.CACHE_TTL * 0.9))
# Some (unknown) tests probably depend on consistent ordering in unbound responses
self._ub_ctx.set_option("cache-max-negative-ttl:", str(settings.CACHE_TTL * 0.9))
# Some may depend on consistent ordering in unbound responses
# https://github.com/internetstandards/Internet.nl/pull/613#discussion_r892196819
# https://github.com/internetstandards/Internet.nl/pull/1292#discussion_r1505778673
self._ub_ctx.set_option("rrset-roundrobin:", "no")
self._ub_ctx.set_option("cache-max-ttl:", str(settings.CACHE_TTL * 0.9))
# XXX: Remove for now; inconsistency with applying settings on celery.
# YYY: Removal caused infinite waiting on pipe to unbound. Added again.
self._ub_ctx.set_async(True)
Expand Down

0 comments on commit 07b069a

Please sign in to comment.