Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to disable lending buttons #9955

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jimchamp
Copy link
Collaborator

Adds disable_lending configuration and new public function that returns this configuration's value.

Adds new UnavailbleButton macro, which is returned by LoanStatus when disable_lending is true.

The suggested call to action overflowed for all buttons in desktop views. As a result, the copy has been updated to read "Currently Unavailable." Unfortunately, this copy overflows in carousels, but fits in other contexts.

Screenshot 2024-10-17 083437

Screenshot 2024-10-17 083527
Book page desktop

Screenshot 2024-10-17 090904
In carousel

Technical

Testing

  1. Set the disable_lending configuration to True
  2. Verify that lending buttons have the expected call to action.

Screenshot

Stakeholders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant