-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show toolbar and follow button for list visitor #9908
base: master
Are you sure you want to change the base?
Show toolbar and follow button for list visitor #9908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @schu96! This is working well, but there are two things that are bothering me:
- There are two sets of navigation breadcrumbs.
- The
databarView
macro doesn't appear in the top-right corner of the view.
I've left some suggested code changes that will partially address number 2. In addition to those changes, you'll have to remove the breadcrumbs and the duplicate databarView
, here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, so good. The duplicate breadcrumbs and databarView
are here, and should be removed.
Whoops, thanks for the reminder I had a complete airhead moment there |
for more information, see https://pre-commit.ci
Closes #9337
Fix
Technical
Remove
if/else
condition, uses thelst['key']
to determine if the user is the owner of the list and show relevant components within theaccount/view.html
template.Testing
Following
tab.Screenshot
Stakeholders
@jimchamp