Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show toolbar and follow button for list visitor #9908

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

schu96
Copy link
Contributor

@schu96 schu96 commented Sep 25, 2024

Closes #9337

Fix

Technical

Remove if/else condition, uses the lst['key'] to determine if the user is the owner of the list and show relevant components within the account/view.html template.

Testing

  • Create two user accounts and use one account to create a list of books
  • Navigate to the list page and check that the follow button does not appear within the list of lists and single list webpages.
  • Sign out of the list creator account and sign into the other newly created account.
  • Navigate to the created book list, verify that the follow button appears on the list page and that pressing follow will add the creator's account to the visitor's Following tab.

Screenshot

image
image
image
image

Stakeholders

@jimchamp

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @schu96! This is working well, but there are two things that are bothering me:

Screenshot 2024-10-01 105524

  1. There are two sets of navigation breadcrumbs.
  2. The databarView macro doesn't appear in the top-right corner of the view.

I've left some suggested code changes that will partially address number 2. In addition to those changes, you'll have to remove the breadcrumbs and the duplicate databarView, here.

openlibrary/templates/account/view.html Outdated Show resolved Hide resolved
openlibrary/templates/account/view.html Outdated Show resolved Hide resolved
openlibrary/templates/type/list/view.html Outdated Show resolved Hide resolved
@jimchamp jimchamp added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Oct 1, 2024
@github-actions github-actions bot removed the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Oct 7, 2024
@jimchamp jimchamp added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Oct 8, 2024
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, so good. The duplicate breadcrumbs and databarView are here, and should be removed.

@github-actions github-actions bot removed the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Oct 8, 2024
@schu96
Copy link
Contributor Author

schu96 commented Oct 8, 2024

Whoops, thanks for the reminder I had a complete airhead moment there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix List pages so MyBooks sidebar + Follows btn appear
2 participants