Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link tracks to all download options #9837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

merwhite11
Copy link
Collaborator

@merwhite11 merwhite11 commented Sep 2, 2024

Closes #9782

Adds link tracks to all download options in sidebar so that we can have a baseline reading of patron activity. This reading will then be used to compare the effectiveness of the work-in-progress Read dropdown redesign
.

Testing

Click a download option and ensure that data for SideBar|Download is being recorded in stats.

Stakeholders

@cdrini @mekarpeles
@SivanC -- just letting you know about this one for when you want to compare SideBar|Download with your eventual ReadDropper|Download feature.

Copy link
Member

@mekarpeles mekarpeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want different actions for the different download types. Instead of Sidebar, you might want to call that Download and then after the | the type

e.g. Download|HTML

@merwhite11
Copy link
Collaborator Author

merwhite11 commented Sep 5, 2024

@mekarpeles I see what you're saying. How then would we distinguish the Download | HTML in Sidebar from a click on Sivan's (future) Download | HTML in the Read dropdown?

@mekarpeles
Copy link
Member

mekarpeles commented Sep 15, 2024

One option is to have something like Download|HTML_sidebar or DownloadSidebar|HTML. It depends how we want to split / roll-up the analytics.

Is it most useful to see the total number of downloads? The total number of downloads per type? Either way, so long as we segment/bucket the types we should be able to see what we need -- it just may take 2 queries + manual maths to get the totals we want.

I haven't spent much time thinking about the best solution. If we did Download|<Format>_<Location> then we'd get a total number of downloads and we'd be able to be able to easily add up the Format counts per Location. So that might be my strategy.

@mekarpeles mekarpeles added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Sep 15, 2024
@merwhite11
Copy link
Collaborator Author

@mekarpeles I agree with the Download|<Format>_<Location> strategy. I will run by Drini before I make the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Link Tracks to Download Hrefs
2 participants