Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add free-form subject field to contact form #8896

Merged

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Mar 12, 2024

Closes #8890

Replaces "Topic" drop-down with a "Subject" input on our /contact page.

Subject lines for support emails will read:
Support case *{subject}*

... where subject is the given subject string, truncated to 60 characters, or [no subject] if the field was left blank by the submitter.

Technical

Testing

The following cases have been tested:

  1. Sending a support email with no subject
  2. Sending a support email with a subject shorter than 60 characters
  3. Sending an email with a subject longer than 60 characters

Screenshot

Stakeholders

@jimchamp jimchamp added On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing and removed Needs: Testing labels Mar 13, 2024
@mekarpeles mekarpeles self-assigned this Mar 14, 2024
@mekarpeles mekarpeles merged commit 067edbc into internetarchive:master Mar 15, 2024
3 checks passed
rebecca-shoptaw pushed a commit to rebecca-shoptaw/openlibrary that referenced this pull request Mar 19, 2024
* Add free-form subject field to contact form & remove dead markup

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Mar 19, 2024
* Add free-form subject field to contact form & remove dead markup

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
rebecca-shoptaw pushed a commit to rebecca-shoptaw/openlibrary that referenced this pull request Mar 19, 2024
* Add free-form subject field to contact form & remove dead markup

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
merwhite11 pushed a commit to merwhite11/openlibrary that referenced this pull request Mar 27, 2024
* Add free-form subject field to contact form & remove dead markup

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
@jimchamp jimchamp deleted the 8890/feature/useful-subject-lines branch April 24, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fixed subject line from contact form
2 participants