-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Dumps: Add Sentry error logging #6319
Data Dumps: Add Sentry error logging #6319
Conversation
Chatted on call:
Note we might need to pass in the path to the openlibrary.yml; I can't recall if importing it this way does the magic for local/prod environment. |
03a572b
to
bff4e18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm (excluding that typo :P )! Can you try testing it by running the dump.py script locally, and copying the dsn into your local openlibrary.yml? Should see first event appear in sentry UI :)
Co-authored-by: Drini Cami <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on call with Chris running it locally with correct DSN; appeared in sentry UI 👍
Need to test a full data dump as well later
As discussed in several issues related to #5402 our data dumps can be quite tricky so this PR logs data dump error output into Sentry to ease debugging.
Technical
Testing
See the cron workflow at #5892
Screenshot
Stakeholders