Replace urlopen with requests in openlibrary/views/showmarc #4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Feb 2, 2021
cclauss
reviewed
Feb 2, 2021
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
cclauss
approved these changes
Feb 2, 2021
hornc
reviewed
Feb 2, 2021
hornc
reviewed
Feb 2, 2021
Co-authored-by: Drini Cami <[email protected]>
Co-authored-by: Charles Horn <[email protected]>
cclauss
approved these changes
Feb 5, 2021
mekarpeles
reviewed
Feb 6, 2021
|
@hornc Do you approve? |
|
@cclauss The URLs still result in unnecessary redirects -- all archive.org URLs should be |
|
I must have overlooked the URL comment, sorry. I'll update it later tonight. |
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 15, 2021
…archive#4527) * Replace urlopen with requests. * Update openlibrary/views/showmarc.py Co-authored-by: Christian Clauss <[email protected]> * Update openlibrary/views/showmarc.py Co-authored-by: Christian Clauss <[email protected]> * Update openlibrary/views/showmarc.py Co-authored-by: Drini Cami <[email protected]> * Update openlibrary/views/showmarc.py Co-authored-by: Charles Horn <[email protected]> * use https and remove www subdomain. Co-authored-by: Christian Clauss <[email protected]> Co-authored-by: Drini Cami <[email protected]> Co-authored-by: Charles Horn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #2852
Refactor showmarc to replace urlopen with requests.
Technical
Refactor showmarc to replace urlopen with requests.
Some pylint and pycodestyle changes for formatting.
Testing
Screenshot
N/A
Stakeholders
@cclauss @hornc