2852/refactor/replace urllib with requests ol infobase #4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do the black and isort thing only on brand new files. Running these on existing files creates too much churn which makes changes too hard to see/review. |
|
Ok - I'll hold off isort in the future. I did use three separate commits, so you could see only the simplejson/urllib changes in the last commit. |
cclauss
reviewed
Jan 14, 2021
cclauss
reviewed
Jan 14, 2021
cclauss
reviewed
Jan 18, 2021
cclauss
approved these changes
Jan 18, 2021
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…ve#4419) * Resolves lint warnings with reformatting, et al. * Ran isort --profile black on ol_infobase * Replace simplejson with json and urlopen with requests.get * use more descriptive name, and add named param for requests.get * Requests raise_for_status() needs to be called from a response Co-authored-by: Christian Clauss <[email protected]>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…ve#4419) * Resolves lint warnings with reformatting, et al. * Ran isort --profile black on ol_infobase * Replace simplejson with json and urlopen with requests.get * use more descriptive name, and add named param for requests.get * Requests raise_for_status() needs to be called from a response Co-authored-by: Christian Clauss <[email protected]>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…ve#4419) * Resolves lint warnings with reformatting, et al. * Ran isort --profile black on ol_infobase * Replace simplejson with json and urlopen with requests.get * use more descriptive name, and add named param for requests.get * Requests raise_for_status() needs to be called from a response Co-authored-by: Christian Clauss <[email protected]>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…ve#4419) * Resolves lint warnings with reformatting, et al. * Ran isort --profile black on ol_infobase * Replace simplejson with json and urlopen with requests.get * use more descriptive name, and add named param for requests.get * Requests raise_for_status() needs to be called from a response Co-authored-by: Christian Clauss <[email protected]>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…ve#4419) * Resolves lint warnings with reformatting, et al. * Ran isort --profile black on ol_infobase * Replace simplejson with json and urlopen with requests.get * use more descriptive name, and add named param for requests.get * Requests raise_for_status() needs to be called from a response Co-authored-by: Christian Clauss <[email protected]>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 15, 2021
…ve#4419) * Resolves lint warnings with reformatting, et al. * Ran isort --profile black on ol_infobase * Replace simplejson with json and urlopen with requests.get * use more descriptive name, and add named param for requests.get * Requests raise_for_status() needs to be called from a response Co-authored-by: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2852
Refactor to replace simplejson with json, and urlopen with requests.get. The first two commits resolve the lint warnings and runs
isort --profile blackto reorder the imports.Technical
Some reformatting to remove lint warnings.
Testing
Unit tests run, and can run the site using
docker-compose upScreenshot
N/A
Stakeholders
@cclauss