use requests instead of stdlib #3658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please move the changes to
When I revert the changes to query.py and then run OL dev on Docker, the system boots and seems highly functional!!! More testing ahead... |
|
@aasifkhan7 Can you please rebase this PR? Can you please put the changes for the file |
added 2 commits
September 29, 2020 02:22
|
@aasifkhan7 Can you please move the changes to |
|
@cclauss Yes sure. I will do that soon. |
|
Too many conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2852
@cclauss used requests instead of urllib as well as removed imports of simplejson whereever possible in multiple files.