Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Project Runeberg as trusted book provider #9983

Open
1 task
Freso opened this issue Nov 3, 2024 · 0 comments · May be fixed by #9984
Open
1 task

Add Project Runeberg as trusted book provider #9983

Freso opened this issue Nov 3, 2024 · 0 comments · May be fixed by #9984
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@Freso
Copy link
Contributor

Freso commented Nov 3, 2024

Proposal

Project Runeberg is a project similar to Project Gutenberg, but with a focus on Nordic/Scandinavian authors and literature.

It would be great to have Runeberg used as a trusted book provider, similar to how Gutenberg is currently used.

Justification

Problem:

We want more web books in Open Library, and we also want more diversified, non-English literature. Project Runeberg provides us both! Similar to Project Gutenberg, Runeberg takes literature that has fallen into the public domain, gets scans of them, OCRs them, and then has humans do proof‐reading of the books. When the books have been prepared, they are published to the public, in the public domain.

Impact:

Idk. More books and more non-English literature in OL? :)

Research:

We already support Project Gutenberg. This should be pretty similar feature-wise.

Breakdown

Requirements Checklist

Related files

  • openlibrary/book_providers.py
  • openlibrary/macros/RawQueryCarousel.html
  • openlibrary/plugins/worksearch/code.py
  • openlibrary/plugins/worksearch/schemes/works.py
  • openlibrary/plugins/worksearch/tests/test_worksearch.py
  • openlibrary/templates/book_providers/runeberg_download_options.html (needs adding)
  • openlibrary/templates/book_providers/runeberg_read_button.html (needs adding)

Stakeholders

Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@Freso Freso added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] labels Nov 3, 2024
Freso added a commit to Freso/openlibrary that referenced this issue Nov 3, 2024
@Freso
Add Project Runeberg as a trusted book provider
ed44791 
This is mostly copy/pasting of existing support for Project Gutenberg,
with a `s/[gG]utenberg/[rR]uneberg/` replacement, but some things have
had additional adjustment (like the `download_options` HTML page).

Fixes internetarchive#9983
@Freso Freso linked a pull request Nov 3, 2024 that will close this issue
Draft
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Lead labels Nov 4, 2024
Freso added a commit to Freso/openlibrary that referenced this issue Nov 5, 2024
@Freso
Add Project Runeberg as a trusted book provider
4fd2371 
This is mostly copy/pasting of existing support for Project Gutenberg,
with a `s/[gG]utenberg/[rR]uneberg/` replacement, but some things have
had additional adjustment (like the `download_options` HTML page).

Fixes internetarchive#9983
Freso added a commit to Freso/openlibrary that referenced this issue Nov 19, 2024
@Freso
Add Project Runeberg as a trusted book provider
355989d 
This is mostly copy/pasting of existing support for Project Gutenberg,
with a `s/[gG]utenberg/[rR]uneberg/` replacement, but some things have
had additional adjustment (like the `download_options` HTML page).

Fixes internetarchive#9983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Project Runeberg as a trusted book provider Freso/openlibrary
2 participants
@Freso @mekarpeles