Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageChanged added and replaced with events.pageChanged #658

Closed
wants to merge 2 commits into from
Closed

pageChanged added and replaced with events.pageChanged #658

wants to merge 2 commits into from

Conversation

Abhir-24
Copy link

As mentioned in the issue, the pagechanged has been added in events.js and in all other files pageChanged has been replaced with events.pageChanged. This issue solves #460

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #658 (7a63344) into master (7096e01) will decrease coverage by 0.24%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   66.84%   66.60%   -0.25%     
==========================================
  Files          35       36       +1     
  Lines        3876     3890      +14     
  Branches      747      745       -2     
==========================================
  Hits         2591     2591              
- Misses       1029     1039      +10     
- Partials      256      260       +4     
Impacted Files Coverage Δ
src/js/BookReader/events.js 100.00% <ø> (ø)
src/js/plugins/search/view.js 48.43% <0.00%> (ø)
src/js/BookReader/Mode2Up.js 56.19% <32.14%> (-2.94%) ⬇️
src/js/BookReader.js 69.73% <88.88%> (-0.08%) ⬇️
src/js/BookReader/ImageCache.js 95.45% <95.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58abb99...7a63344. Read the comment docs.

@Abhir-24
Copy link
Author

@iisa can u pls help me out that what is going wrong in my PR?

@Abhir-24 Abhir-24 closed this Oct 1, 2021
@Abhir-24 Abhir-24 deleted the mybranch branch October 1, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant