Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataDownloader#1374: Compare to existing version before downloading #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DataDownloader#1374: Compare to existing version before downloading #11

wants to merge 1 commit into from

Conversation

IamMujuziMoses
Copy link

@IamMujuziMoses IamMujuziMoses mentioned this pull request Oct 17, 2020
Open
@IamMujuziMoses
Copy link
Author

@sergiocontrino I would like to contribute to this issue please review this PR, thanx

@sergiocontrino
Copy link
Member

i don't see how it works (it seems to compare directories names rather than versions? are naming comparable? does it need to get current remote version via webservice?) but it could be my poor perl. probably @rachellyne has a better idea of workings here.
i would change the message though, something like:
$self->get_title . " already up to date (version " . $version . "), skipping download"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IamMujuziMoses @sergiocontrino