Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting SVG icons #215

Closed
wants to merge 1 commit into from
Closed

Supporting SVG icons #215

wants to merge 1 commit into from

Conversation

Manasa2850
Copy link
Contributor

Fixes issue #168
The latest version of font awesome 5.12.1 supports SVG so I've updated the version from 4.7.0 to 5.12.1

@heralden
Copy link
Member

heralden commented Dec 1, 2020

I apologise for the very late feedback!

Thank you for looking into the issue.

I believe the intent of #168 was to use SVGs instead of the fontawesome font. Updating fontawesome won't be enough to achieve this; we'd need to include all of the SVG sources and reference them as specified here (in other words, a pretty substantial change). I am sorry for the confusion!

I will be closing this PR as I'm not expecting a response after this long time. You are welcome to open another PR if you wish to tackle this issue again.

@heralden heralden closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants