Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for license list version and creator comments #70

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add support for license list version and creator comments #70

merged 1 commit into from
Jul 8, 2024

Conversation

riteshnoronha
Copy link
Contributor

  1. Pick the latest version of license list version, if its missing we omit this field.
  2. Added creator comments from all documents joined together.

@riteshnoronha riteshnoronha linked an issue Jul 8, 2024 that may be closed by this pull request
LicenseListVersion creates invalid SPDX #67
Closed
@riteshnoronha riteshnoronha mentioned this pull request Jul 8, 2024
Closed
surendrapathak
surendrapathak approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@surendrapathak surendrapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riteshnoronha riteshnoronha merged commit 19291e2 into main Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surendrapathak surendrapathak surendrapathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LicenseListVersion creates invalid SPDX
2 participants
@riteshnoronha @surendrapathak