Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixes #2962 #3000

Merged
merged 3 commits into from
Sep 24, 2024
Merged

docs: fixes #2962 #3000

merged 3 commits into from
Sep 24, 2024

Conversation

melissahenderson
Copy link
Contributor

Also deleted blank peering.mdx page

@melissahenderson
docs: fixes #2962
ef21c4f 
Also deleted blank peering.mdx page
@github-actions github-actions bot added pkg: frontend Changes in the frontend package. pkg: documentation Changes in the documentation package. labels Sep 23, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 16cec80
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66f2d07cb531720008d18c36
😎 Deploy Preview https://deploy-preview-3000--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

brad-dow
brad-dow requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@brad-dow brad-dow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In backend-service.mdx, line 54: REDIS should be Redis.

The rest looks good from what I can see on Github. Looks like it didn't generate a deploy preview link.

@melissahenderson
Copy link
Contributor Author

@brad-dow Updated. There's also a preview link now. I'm not sure why that wasn't there initially.

@melissahenderson melissahenderson merged commit 2ca8bf4 into main Sep 24, 2024
29 of 42 checks passed
@melissahenderson melissahenderson deleted the mh-2962 branch September 24, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brad-dow brad-dow brad-dow approved these changes

@hajjimo hajjimo Awaiting requested review from hajjimo

Assignees
No one assigned
Labels
pkg: documentation Changes in the documentation package. pkg: frontend Changes in the frontend package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melissahenderson @brad-dow