-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make rafiki admin auth optional #2883
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
I assume I should remove all auth stuff from the localenv README then? No mention of Kratos, or mailslurper etc. Change the architecture diagram etc.? I guess my hesitation here is because to lose that information here makes me feel like we need it elsewhere then and this becomes a bit of a bigger docs discussion. Perhaps it's needed in the bigger architecture diagram instead of just in localenv? This may be true regardless but it also means that we don't have visual access to the ports for accessing e.g. mailslurper anymore. Perhaps we need to break this out into a docs issue? |
@melissahenderson and @brad-dow please just have a look at the README updates. Is it still okay to publish these while we're on a docs hold? Also note, we'll need these changes reflected in the Local Playground, and Rafiki Admin docs when they're updated as well. |
A lot of the changes are repeated because I consolidated all the new logic from the redirect functions into a single |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll see some custom logic here and in the sidebar component because the logout button and account settings menu item should only appear if auth is enabled and a user is logged in.
959a1c0
to
fc1c526
Compare
fc1c526
to
adbb734
Compare
@JoblersTune (and @brad-dow) I think it's OK to push the changes to the README since it's outside of |
I say go ahead and merge this. When the README discussion happens, we make sure all agree which bits we remove (if at all, because I don't really foresee major changes to the READMEs, maybe just tweaking of wording here and there) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melissahenderson the local playground changes would be something along these lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melissahenderson and these kinds of changes in the Rafiki Admin docs
Changes proposed in this pull request
Context
Fixes #2806
Checklist
fixes #number