Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): set session expiry based on interaction expiry env #2851

Merged
merged 1 commit into from
Aug 9, 2024
Merged

feat(auth): set session expiry based on interaction expiry env #2851

merged 1 commit into from
Aug 9, 2024

Conversation

njlie
Copy link
Contributor

@njlie njlie commented Aug 8, 2024

Changes proposed in this pull request

  • Sets the maxAge of a koa-session, and by extension, session cookies, to be based off of the value of the interaction expiry environment variable.

Context

Closes #2850

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@github-actions github-actions bot added type: source Changes business logic pkg: auth Changes in the GNAP auth package. labels Aug 8, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 8, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit df0eb84
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66b4cfa380ad0d00082b69ff

@njlie
Copy link
Contributor Author

njlie commented Aug 8, 2024

Note to self: do NOT pull docker images on really crappy hostel internet

@njlie njlie marked this pull request as ready for review August 8, 2024 15:09
BlairCurrey
BlairCurrey approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@BlairCurrey BlairCurrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I see the longer expiry in redis and the cookie.

@njlie njlie merged commit d4ebe14 into main Aug 9, 2024
42 checks passed
@njlie njlie deleted the nl/2850/fix-session-expiry branch August 9, 2024 06:32
sabineschaller pushed a commit that referenced this pull request Aug 15, 2024
@njlie @sabineschaller
feat(auth): set session expiry based on interaction expiry env (#2851)
3dbd870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragosp1011 dragosp1011 dragosp1011 approved these changes

@mkurapov mkurapov mkurapov approved these changes

@BlairCurrey BlairCurrey BlairCurrey approved these changes

@Tymmmy Tymmmy Awaiting requested review from Tymmmy

Assignees
No one assigned
Labels
pkg: auth Changes in the GNAP auth package. type: source Changes business logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix max age for auth session cookie
4 participants
@njlie @BlairCurrey @mkurapov @dragosp1011