Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync docs and readmes #2830

Merged
merged 6 commits into from
Jul 31, 2024
Merged

chore: sync docs and readmes #2830

merged 6 commits into from
Jul 31, 2024

Conversation

JoblersTune
Copy link
Collaborator

@JoblersTune JoblersTune commented Jul 31, 2024 •
edited
Loading

Changes proposed in this pull request

  • As I started working on updating the Admin UI and Kratos docs I noticed the localenv README and the localenv docs are pretty much the same but had slight divergences. So I brought them back in line.
  • While doing that I also noticed the MASE images were outdated so I added new screenshots in.
  • I also updated the code block language identifiers to have consistent approach through the docs

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@JoblersTune JoblersTune self-assigned this Jul 31, 2024
@github-actions github-actions bot added type: localenv Local playground pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation labels Jul 31, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 31, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 69a33a3
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66a9dda6ced44e0008429094

@JoblersTune JoblersTune changed the title Sj sync docs and readmes chore: sync docs and readmes Jul 31, 2024
@melissahenderson
Copy link
Contributor

melissahenderson commented Jul 31, 2024 •
edited
Loading

@hajjimo @brad-dow I wanted to make you aware of Sarah's updates. They affect the doc revisions we're currently working on.

@JoblersTune JoblersTune merged commit 752bb73 into main Jul 31, 2024
36 of 42 checks passed
@JoblersTune JoblersTune deleted the sj-sync-docs-and-readmes branch July 31, 2024 13:54
sabineschaller pushed a commit that referenced this pull request Aug 15, 2024
@JoblersTune @sabineschaller
chore: sync docs and readmes (#2830)
ba203bc 
* fix: getting the localenv docs and readme in sync

* chore: updated MASE screenshots

* chore: updating the code block language identifier to have consistent approach through the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissahenderson melissahenderson melissahenderson approved these changes

@huijing huijing Awaiting requested review from huijing

Assignees

@JoblersTune JoblersTune

Labels
pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation type: localenv Local playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoblersTune @melissahenderson