chore(backend): estimate ILP quote receive amount, and fail early #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
mkurapov
force-pushed
the
2770/mk/minimum-delivery-amount
branch
from
20dc3c7
to
4ce6353
Compare
mkurapov
changed the title
mkurapov
changed the title
mkurapov
commented
Jun 25, 2024
Comment on lines
+167
to
+172
| if ( | ||
| err instanceof PaymentMethodHandlerError && | ||
| err.code === PaymentMethodHandlerErrorCode.QuoteNonPositiveReceiveAmount | ||
| ) { | ||
| return QuoteError.NonPositiveReceiveAmount | ||
| } |
There was a problem hiding this comment.
Handle gracefully, avoid returning 500 for an unhandled PaymentMethodHandlerError.
This is also prepping for having better error codes in the RS in general.
sabineschaller
previously approved these changes
Jun 25, 2024
| receiver: receiver.incomingPayment!.id, | ||
| method: 'ilp', | ||
| debitAmount: { | ||
| value: 2n, |
There was a problem hiding this comment.
Why does that end up being non-positive? Because of slippage?
There was a problem hiding this comment.
We mock the call to paymentMethodHandlerService.getQuote so this value doesn't matter too much.
Main test is here
raducristianpopa
previously approved these changes
Jun 26, 2024
mkurapov
dismissed stale reviews from raducristianpopa and sabineschaller
via
1897492
mkurapov
force-pushed
the
2770/mk/minimum-delivery-amount
branch
from
1897492
to
83493b1
Compare
raducristianpopa
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Error during quoting if the ILP quote will not fulfil at least a single unit of the receiving asset. See #2770 for detailed explanation.
Context
Fixes #2770
Checklist
fixes #number