Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): ip lookup, atomic asset creation, document updates. #2776

Merged
merged 50 commits into from
Jul 29, 2024
Merged

feat(backend): ip lookup, atomic asset creation, document updates. #2776

merged 50 commits into from
Jul 29, 2024

Conversation

koekiebox
Copy link
Collaborator

@koekiebox koekiebox commented Jun 15, 2024 •
edited
Loading

Changes proposed in this pull request

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@koekiebox koekiebox self-assigned this Jun 15, 2024
@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation labels Jun 15, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 15, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 7be049e
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66a79df212414c00087eb861
😎 Deploy Preview https://deploy-preview-2776--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@koekiebox koekiebox mentioned this pull request Jun 15, 2024
Closed
9 tasks
@koekiebox koekiebox changed the title feat(2756):ip lookup, atomic asset creation, document updates. feat(backend): ip lookup, atomic asset creation, document updates. Jun 17, 2024
@github-actions github-actions bot added the type: tests Testing related label Jun 17, 2024
@github-actions github-actions bot added the type: ci Changes to the CI label Jun 18, 2024
@github-actions github-actions bot added the type: localenv Local playground label Jul 24, 2024
@melissahenderson
Copy link
Contributor

@koekiebox Most recent doc updates look good to me. Not sure if I should be the one to approve the PR given all the other updates.

mkurapov
mkurapov reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for another big batch of comments, mostly just small things!

packages/backend/src/accounting/psql/service.test.ts Show resolved Hide resolved
packages/backend/src/accounting/psql/ledger-transfer/model.ts Outdated Show resolved Hide resolved
packages/backend/src/accounting/psql/service.test.ts Show resolved Hide resolved
packages/backend/src/config/app.ts Outdated Show resolved Hide resolved
packages/backend/src/accounting/psql/service.ts Outdated Show resolved Hide resolved
packages/backend/src/graphql/resolvers/accounting_transfer.test.ts Outdated Show resolved Hide resolved
packages/backend/src/graphql/schema.graphql Outdated Show resolved Hide resolved
packages/backend/src/graphql/resolvers/accounting_transfer.test.ts Outdated Show resolved Hide resolved
packages/backend/src/accounting/psql/service.ts Outdated Show resolved Hide resolved
packages/backend/src/accounting/psql/ledger-transfer/index.ts Outdated Show resolved Hide resolved
BlairCurrey
BlairCurrey previously approved these changes Jul 26, 2024
View reviewed changes
mkurapov
mkurapov previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just final thing re: tests mainly

packages/backend/src/accounting/tigerbeetle/service.test.ts Outdated Show resolved Hide resolved
packages/backend/src/accounting/psql/ledger-transfer/index.ts Outdated Show resolved Hide resolved
packages/backend/src/graphql/resolvers/accounting_transfer.tigerbeetle.test.ts Show resolved Hide resolved
@koekiebox koekiebox dismissed stale reviews from mkurapov and BlairCurrey via ace7660 July 28, 2024 11:05
BlairCurrey
BlairCurrey previously approved these changes Jul 29, 2024
View reviewed changes
@koekiebox koekiebox merged commit 82d4f18 into main Jul 29, 2024
36 of 42 checks passed
@koekiebox koekiebox deleted the issues/2756-tigerbeetle-based-0_15_3 branch July 29, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlairCurrey BlairCurrey BlairCurrey approved these changes

@melissahenderson melissahenderson Awaiting requested review from melissahenderson

@mkurapov mkurapov Awaiting requested review from mkurapov

Assignees

@koekiebox koekiebox

Labels
pkg: backend Changes in the backend package. pkg: documentation Changes in the documentation package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: ci Changes to the CI type: documentation (archived) Improvements or additions to documentation type: localenv Local playground type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review TigerBeetle integration based on current TigerBeetle release
4 participants
@koekiebox @melissahenderson @BlairCurrey @mkurapov