-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(2624): add design and modify flow in MASE #2741
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
localenv/mock-account-servicing-entity/app/components/Button.tsx
Outdated
Show resolved
Hide resolved
A few of us took a look at the screenshots, and had some comments: In general, looks much better, thank you! Some thoughts we had:
I'll start a thread in slack in case someone else had additional thoughts. |
The update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Main concern is the rates route that prevents the rates lookup from the backend service
localenv/mock-account-servicing-entity/app/routes/rates._index.tsx
Outdated
Show resolved
Hide resolved
localenv/mock-account-servicing-entity/app/routes/accounts.$accountId.tsx
Show resolved
Hide resolved
localenv/mock-account-servicing-entity/app/routes/accounts.$accountId.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes proposed in this pull request
solves most of #2624
shoe-shop
page/url tomock-idp/consent
for it to make more senseContext
Checklist
fixes #number