Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2624): add design and modify flow in MASE #2741

Merged
merged 31 commits into from
Jun 10, 2024

Conversation

lengyel-arpad85
Copy link
Contributor

@lengyel-arpad85 lengyel-arpad85 commented May 22, 2024

Changes proposed in this pull request

solves most of #2624

  • removed / renamed shoe-shop page/url to mock-idp/consent for it to make more sense
  • added functionality to create a new account
  • added edit account functionality & a way to add funds to an account
  • added consistent design to pages (see screenshots)
  • made modifications to the consent pages, in structure and design
Screenshots (v2)

Screenshots (old)

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@lengyel-arpad85 lengyel-arpad85 marked this pull request as draft May 22, 2024 21:42
Copy link

netlify bot commented May 22, 2024

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit c657cc7
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6660bc1862d4970008e629bd

@lengyel-arpad85 lengyel-arpad85 self-assigned this May 22, 2024
@lengyel-arpad85 lengyel-arpad85 linked an issue May 22, 2024 that may be closed by this pull request
@lengyel-arpad85 lengyel-arpad85 marked this pull request as ready for review May 25, 2024 18:41
Tymmmy
Tymmmy previously approved these changes May 28, 2024
@mkurapov
Copy link
Contributor

A few of us took a look at the screenshots, and had some comments:

In general, looks much better, thank you!
The main thing we wanted to do was to distinguish it a bit more from the Admin UI, just to avoid any confusion for people working through the local playground, between what would be part of Rafiki, or something external.

Some thoughts we had:

  • Adding the name of the instance (eg "Happy Life Bank" or "Cloud Nine Wallet") instead of "Mock ASE" , and adding some kind of icon to go along with it, either the wallet icon (like the one in the new test wallet/rafiki.money redesign) or the bank icon
  • Adding something like global disclaimer to the footer of the page, explaining that this is just a "Mock ASE" and not for use as a production interface
  • Mainly to differentiate from the Rafiki UI, there was an idea was to move the two tabs to the top of the page (at least somewhere other than the left side bar)
  • And in general, some minor changes in the color, to contribute to the separation between the mock ASE and Admin UI

I'll start a thread in slack in case someone else had additional thoughts.

@lengyel-arpad85
Copy link
Contributor Author

A few of us took a look at the screenshots, and had some comments:

In general, looks much better, thank you! The main thing we wanted to do was to distinguish it a bit more from the Admin UI, just to avoid any confusion for people working through the local playground, between what would be part of Rafiki, or something external.

Some thoughts we had:

  • Adding the name of the instance (eg "Happy Life Bank" or "Cloud Nine Wallet") instead of "Mock ASE" , and adding some kind of icon to go along with it, either the wallet icon (like the one in the new test wallet/rafiki.money redesign) or the bank icon
  • Adding something like global disclaimer to the footer of the page, explaining that this is just a "Mock ASE" and not for use as a production interface
  • Mainly to differentiate from the Rafiki UI, there was an idea was to move the two tabs to the top of the page (at least somewhere other than the left side bar)
  • And in general, some minor changes in the color, to contribute to the separation between the mock ASE and Admin UI

I'll start a thread in slack in case someone else had additional thoughts.

The update:

  • changed left menubar to top menu
  • added the separate logos and background image for each instance
  • added instance name to meta title and topmenu
  • added infobar to bottom of pages with the disclaimer
  • changed colors used (see new screenshots)

@lengyel-arpad85 lengyel-arpad85 requested review from Tymmmy and mkurapov and removed request for mkurapov May 30, 2024 17:50
Tymmmy
Tymmmy previously approved these changes Jun 3, 2024
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Main concern is the rates route that prevents the rates lookup from the backend service

Tymmmy
Tymmmy previously approved these changes Jun 4, 2024
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final thing, creating an account creates the wallet address correctly in the backend, but shows up as doubled on the accounts page:
Screenshot 2024-06-05 at 11 54 28

@lengyel-arpad85 lengyel-arpad85 merged commit f3093ba into main Jun 10, 2024
42 checks passed
@lengyel-arpad85 lengyel-arpad85 deleted the 2624/al/make-mase-a-better-place branch June 10, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the MASE a better place™
4 participants