Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature needs to be escaped for POST methods #15

Open
jordanmhiller opened this issue Mar 7, 2018 · 1 comment
Open

Signature needs to be escaped for POST methods #15

jordanmhiller opened this issue Mar 7, 2018 · 1 comment

Comments

@jordanmhiller
Copy link

Amazon::MWS::Routines::sign_request sometimes pads the signature with "=", but it neglects to escape the signature when included in the request body.

For example, when trying to use CreateInboundShipmentPlan I received the following error from Amazon:

<?xml version="1.0"?> <ErrorResponse xmlns="https://mws.amazonservices.com/"> <Error> <Type>Sender</Type> <Code>InvalidParameterValue</Code> <Message>Invalid query string provided - AWSAccessKeyId=...&amp;Signature=...A= is not valid; the value of a query string parameter may not contain a &apos;=&apos; delimiter</Message> </Error> <RequestID>...</RequestID> </ErrorResponse>

The attached patch seems to solve the issue for me.

Routines.pm.patch.txt

racke added a commit that referenced this issue Mar 17, 2018
@racke
Copy link
Member

racke commented Mar 17, 2018

Thanks a lot, @jordanmhiller. I applied the patch through 412484c. If you want your real name in ACKNOWLEDGEMENTS, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants