Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Fixes #1550, checking number of namespace elements in requested metric #1551

Merged
merged 1 commit into from
Mar 20, 2017
Merged

Fixes #1550, checking number of namespace elements in requested metric #1551

merged 1 commit into from
Mar 20, 2017

Conversation

katarzyna-z
Copy link
Contributor

Fixes #1550

Summary of changes:

  • Added checking of number of namespace elements in requested metric

$ in task manifest indicates env variable. If variables are not set then namespace is empty.
Currently for empty namespace user will see following message:

Using task manifest to create task
Error creating task:Incorrect format of requested metric, empty list of namespace elements

Testing done:

  • small, medium tests

@intelsdi-x/snap-maintainers

mkleina
mkleina approved these changes Mar 16, 2017
View reviewed changes
Copy link
Contributor

@mkleina mkleina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrzej-k
andrzej-k approved these changes Mar 16, 2017
View reviewed changes
Copy link
Contributor

@andrzej-k andrzej-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashmigottipati rashmigottipati mentioned this pull request Mar 17, 2017
Closed
@katarzyna-z katarzyna-z merged commit f72a3d6 into intelsdi-x:master Mar 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrzej-k andrzej-k andrzej-k approved these changes

@mkleina mkleina mkleina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katarzyna-z @andrzej-k @mkleina