This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Refactor api and add v2 API (beta) #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- V2 metrics routes now have a metrics section in the body of the response.
- Fixed text case in v2/tests from "ScheduledTasks" to "scheduled_tasks" to be consistent with other responses.
- Added V2 folders in rest and in rbody to hold v2 methods
- Made all v2 tribe routes to be /v2/tribes (made tribe plural) - Changed V2/tribes/member/:name to be V2/tribes/members/:name (made member plural)
Created V2 REST API Routes in feature branch snap/v2_rest_api
kindermoumoute
force-pushed
the
refactor_API
branch
from
638aaad to
d09e01a
Compare
kindermoumoute
force-pushed
the
refactor_API
branch
from
d09e01a to
389d7fe
Compare
Implements the API interface to v1.
kindermoumoute
force-pushed
the
refactor_API
branch
from
6c191eb to
da7e778
Compare
|
The review of this PR has been done in #1474, this PR is just a rebase in order to have clear commits in the log. |
kindermoumoute
force-pushed
the
refactor_API
branch
from
0f84e53 to
2e31609
Compare
Closed
kindermoumoute
force-pushed
the
refactor_API
branch
3 times, most recently
from
ccc51c0 to
15c1de2
Compare
Adds version 2 of the rest api in order to have more consistent responses, errors, and conform to REST better. - Add package v2/mock - Add medium tests for v2 - Implement API interface for v2 - Implement v2 routes
kindermoumoute
force-pushed
the
refactor_API
branch
from
15c1de2 to
e741f41
Compare
jcooklin
suggested changes
Jan 25, 2017
| ) | ||
|
|
||
| const ( | ||
| ErrPluginAlreadyLoaded = "plugin is already loaded" |
There was a problem hiding this comment.
Let's take this opportunity to make the errors consistent in terms of language, punctuation and capitalization.
| const ( | ||
| ErrPluginAlreadyLoaded = "plugin is already loaded" | ||
| ErrTaskNotFound = "Task not found" | ||
| ErrTaskDisabledNotRunnable = "Task is disabled. Cannot be started" |
There was a problem hiding this comment.
"Cannot be started" can probably be dropped.
jcooklin
approved these changes
Jan 25, 2017
|
@IRCody, @nanliu, @candysmurf can we get another LGTM? |
IRCody
approved these changes
Jan 25, 2017
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
@intelsdi-x/snap-maintainers