This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Fixes #1229: Empty metric catalog no longer errors #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty metric catalog no longer logs or returns an error when queried via the rest API (or any other method). Will instead return an empty list of metrics, leaving choice of how to display that to the caller. Removes the empty metric catalog error and modifies client_func_test to reflect the changes in behavior.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1229
Summary of changes:
Empty metric catalog no longer logs or returns an error when queried
via the rest API (or any other method). Will instead return an empty
list of metrics, leaving choice of how to display that to the caller.
Removes the empty metric catalog error and modifies client_func_test to
reflect the changes in behavior.
Testing done:
@intelsdi-x/snap-maintainers