Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

on plugin load error snapd should log what the plugin sent to stdout #1105

Closed
jcooklin opened this issue Jul 28, 2016 · 1 comment
Closed

Comments

@jcooklin
Copy link
Collaborator

When snapd starts a plugin and is unable to unmarshal it's stdout the snapd log should include whatever the plugin sent to stdout to facilitate debugging. Today snapd only returns the error from the unmarshal which includes the first letter of whatever was sent to stdout (e.g. "invalid character 'p' looking for beginning of value").

@IRCody
Copy link
Contributor

IRCody commented Jul 28, 2016

I think the rest client does something similar when it has marshaling errors here by returning the first 1k characters of any error to help debugging. Seems like a similar method could be used here.

katarzyna-z added a commit to katarzyna-z/snap that referenced this issue Mar 9, 2017
katarzyna-z added a commit to katarzyna-z/snap that referenced this issue Mar 9, 2017
katarzyna-z added a commit that referenced this issue Mar 16, 2017
Fixes #1105, logging plugin's response to stdout on plugin load error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants